1
0

use MMIO for DMA requests instead of separate channel

This commit is contained in:
Howard Mao 2016-01-14 11:38:16 -08:00
parent 04e1f8c5c3
commit a59ff38b67
2 changed files with 11 additions and 17 deletions

View File

@ -4,7 +4,7 @@ import Chisel._
import uncore._ import uncore._
import uncore.DmaRequest._ import uncore.DmaRequest._
import rocket._ import rocket._
import junctions.PAddrBits import junctions.{PAddrBits, HasAddrMapParameters}
import cde.{Parameters, Field} import cde.{Parameters, Field}
import scala.math.max import scala.math.max
@ -25,18 +25,17 @@ case object DmaTestSet extends Field[Seq[DmaTestCase]]
case object DmaTestDataStart extends Field[Int] case object DmaTestDataStart extends Field[Int]
case object DmaTestDataStride extends Field[Int] case object DmaTestDataStride extends Field[Int]
case object DmaStreamLoopbackAddr extends Field[BigInt]
case object DmaStreamTestSettings extends Field[DmaStreamTestConfig] case object DmaStreamTestSettings extends Field[DmaStreamTestConfig]
class DmaStreamTest(implicit p: Parameters) extends GroundTest()(p) class DmaStreamTest(implicit p: Parameters) extends GroundTest()(p)
with HasDmaParameters with HasCoreParameters { with HasDmaParameters with HasCoreParameters with HasAddrMapParameters {
disablePorts(cache = false, dma = false, ptw = false) disablePorts(cache = false, mem = false, ptw = false)
val (s_start :: s_setup_req :: s_setup_wait :: val (s_start :: s_setup_req :: s_setup_wait ::
s_stream_out :: s_stream_in :: s_stream_wait :: s_stream_out :: s_stream_in :: s_stream_wait ::
s_check_req :: s_check_wait :: s_done :: Nil) = Enum(Bits(), 9) s_check_req :: s_check_wait :: s_done :: Nil) = Enum(Bits(), 9)
val state = Reg(init = s_start) val state = Reg(init = s_start)
val lo_base = p(DmaStreamLoopbackAddr) val lo_base = addrMap("devices:loopback").start
val conf = p(DmaStreamTestSettings) val conf = p(DmaStreamTestSettings)
val test_data = Vec.tabulate(conf.len) { i => UInt(i * 8, conf.size * 8) } val test_data = Vec.tabulate(conf.len) { i => UInt(i * 8, conf.size * 8) }
@ -62,8 +61,8 @@ class DmaStreamTest(implicit p: Parameters) extends GroundTest()(p)
frontend.io.cpu.req.valid := (state === s_stream_out) || (state === s_stream_in) frontend.io.cpu.req.valid := (state === s_stream_out) || (state === s_stream_in)
frontend.io.cpu.req.bits := Mux(state === s_stream_out, out_req, in_req) frontend.io.cpu.req.bits := Mux(state === s_stream_out, out_req, in_req)
io.dma <> frontend.io.dma
io.ptw <> frontend.io.ptw io.ptw <> frontend.io.ptw
io.mem <> frontend.io.mem
val cache_addr_base = Mux(state === s_setup_req, UInt(conf.source), UInt(conf.dest)) val cache_addr_base = Mux(state === s_setup_req, UInt(conf.source), UInt(conf.dest))
@ -92,6 +91,8 @@ class DmaStreamTest(implicit p: Parameters) extends GroundTest()(p)
assert(!io.cache.resp.valid || !io.cache.resp.bits.has_data || assert(!io.cache.resp.valid || !io.cache.resp.bits.has_data ||
resp_data === test_data(resp_index), resp_data === test_data(resp_index),
"Result data streamed in does not match data streamed out") "Result data streamed in does not match data streamed out")
assert(!frontend.io.cpu.resp.valid || frontend.io.cpu.resp.bits.status === UInt(0),
"Frontend error response")
io.finished := (state === s_done) io.finished := (state === s_done)
} }
@ -106,7 +107,7 @@ class DmaTest(implicit p: Parameters) extends GroundTest()(p)
private val wordBytes = wordBits / 8 private val wordBytes = wordBits / 8
private val pAddrBits = p(PAddrBits) private val pAddrBits = p(PAddrBits)
disablePorts(cache = false, dma = false, ptw = false) disablePorts(cache = false, mem = false, ptw = false)
val sourceAddrs = Vec(testSet.map(test => UInt(test.source))) val sourceAddrs = Vec(testSet.map(test => UInt(test.source)))
val destAddrs = Vec(testSet.map(test => UInt(test.dest))) val destAddrs = Vec(testSet.map(test => UInt(test.dest)))
@ -130,8 +131,8 @@ class DmaTest(implicit p: Parameters) extends GroundTest()(p)
dst_start = destAddrs(testIdx), dst_start = destAddrs(testIdx),
segment_size = transferLengths(testIdx)) segment_size = transferLengths(testIdx))
io.dma <> frontend.io.dma
io.ptw <> frontend.io.ptw io.ptw <> frontend.io.ptw
io.mem <> frontend.io.mem
io.cache.req.valid := (state === s_fill_req) || (state === s_check_req) io.cache.req.valid := (state === s_fill_req) || (state === s_check_req)
io.cache.req.bits.addr := req_addr io.cache.req.bits.addr := req_addr
@ -190,9 +191,8 @@ class DmaTest(implicit p: Parameters) extends GroundTest()(p)
assert(!io.cache.resp.valid || !io.cache.resp.bits.has_data || assert(!io.cache.resp.valid || !io.cache.resp.bits.has_data ||
io.cache.resp.bits.data === req_data, "Received data does not match") io.cache.resp.bits.data === req_data, "Received data does not match")
assert(!frontend.io.cpu.resp.valid || frontend.io.cpu.resp.bits.status === UInt(0),
val dma_timeout = Timer(1000, io.dma.req.fire(), io.dma.resp.fire()) "Frontend error response")
assert(!dma_timeout, "DMA request timed out")
val cache_timeout = Timer(1000, io.cache.req.fire(), io.cache.resp.valid) val cache_timeout = Timer(1000, io.cache.req.fire(), io.cache.resp.valid)
assert(!cache_timeout, "Memory request timed out") assert(!cache_timeout, "Memory request timed out")

View File

@ -115,7 +115,6 @@ abstract class GroundTest(implicit val p: Parameters) extends Module {
def disablePorts(mem: Boolean = true, def disablePorts(mem: Boolean = true,
cache: Boolean = true, cache: Boolean = true,
dma: Boolean = true,
ptw: Boolean = true) { ptw: Boolean = true) {
if (mem) { if (mem) {
io.mem.acquire.valid := Bool(false) io.mem.acquire.valid := Bool(false)
@ -124,10 +123,6 @@ abstract class GroundTest(implicit val p: Parameters) extends Module {
if (cache) { if (cache) {
io.cache.req.valid := Bool(false) io.cache.req.valid := Bool(false)
} }
if (dma) {
io.dma.req.valid := Bool(false)
io.dma.resp.ready := Bool(false)
}
if (ptw) { if (ptw) {
io.ptw.req.valid := Bool(false) io.ptw.req.valid := Bool(false)
} }
@ -139,7 +134,6 @@ class GroundTestTile(id: Int, resetSignal: Bool)
val test = p(BuildGroundTest)(id, dcacheParams) val test = p(BuildGroundTest)(id, dcacheParams)
io.uncached.head <> test.io.mem io.uncached.head <> test.io.mem
io.dma <> test.io.dma
val dcache = Module(new HellaCache()(dcacheParams)) val dcache = Module(new HellaCache()(dcacheParams))
val dcacheIF = Module(new SimpleHellaCacheIF()(dcacheParams)) val dcacheIF = Module(new SimpleHellaCacheIF()(dcacheParams))