From df5caba7bf10bec3d4d1cce8f5c5e73a757d2c61 Mon Sep 17 00:00:00 2001
From: Megan Wachs <megan@sifive.com>
Date: Thu, 6 Apr 2017 10:33:17 -0700
Subject: [PATCH] debug: Make it easier to override parts of the Default Debug
 Config (#655)

* Handle single-step with a pipeline stall, not a flush

The pipeline flush approach broke when I changed the pipeline stage
the flush happens from

* debug: Make it easier to override parts of the Default Debug Config

* Fix typo in Debug code generation

abstractGeneratedI should be abstractGeneratedS when pulling out the opcode.
This doesn't actually break anything, but fix it for clarity.
---
 src/main/scala/coreplex/Configs.scala         |  2 +-
 .../scala/uncore/devices/debug/Debug.scala    | 61 ++++++++-----------
 2 files changed, 26 insertions(+), 37 deletions(-)

diff --git a/src/main/scala/coreplex/Configs.scala b/src/main/scala/coreplex/Configs.scala
index 0d7b2a50..29a2d028 100644
--- a/src/main/scala/coreplex/Configs.scala
+++ b/src/main/scala/coreplex/Configs.scala
@@ -22,7 +22,7 @@ class BaseCoreplexConfig extends Config ((site, here, up) => {
   case BuildCore => (p: Parameters) => new Rocket()(p)
   case RocketCrossing => Synchronous
   case RocketTilesKey =>  Nil
-  case DMKey => new DefaultDebugModuleConfig(site(XLen))
+  case DMKey => DefaultDebugModuleConfig(site(XLen))
   case NTiles => site(RocketTilesKey).size
   case CBusConfig => TLBusConfig(beatBytes = site(XLen)/8)
   case L1toL2Config => TLBusConfig(beatBytes = site(XLen)/8) // increase for more PCIe bandwidth
diff --git a/src/main/scala/uncore/devices/debug/Debug.scala b/src/main/scala/uncore/devices/debug/Debug.scala
index 77ab4905..3893b3ad 100644
--- a/src/main/scala/uncore/devices/debug/Debug.scala
+++ b/src/main/scala/uncore/devices/debug/Debug.scala
@@ -109,22 +109,22 @@ import DebugAbstractCommandType._
   **/
 
 case class DebugModuleConfig (
-  nDMIAddrSize  : Int,
-  nProgramBufferWords: Int,
-  nAbstractDataWords : Int,
-  nScratch : Int,
+  nDMIAddrSize  : Int = 7,
+  nProgramBufferWords: Int = 16,
+  nAbstractDataWords : Int = 4,
+  nScratch : Int = 1,
   //TODO: Use diplomacy to decide if you want this.
-  hasBusMaster : Boolean,
-  hasAccess128 : Boolean,
-  hasAccess64  : Boolean,
-  hasAccess32  : Boolean,
-  hasAccess16  : Boolean,
-  hasAccess8   : Boolean,
-  nSerialPorts : Int,
-  supportQuickAccess : Boolean,
-  supportHartArray   : Boolean,
-  hartIdToHartSel : (UInt) => UInt,
-  hartSelToHartId : (UInt) => UInt
+  hasBusMaster : Boolean = false,
+  hasAccess128 : Boolean = false,
+  hasAccess64  : Boolean = false,
+  hasAccess32  : Boolean = false,
+  hasAccess16  : Boolean = false,
+  hasAccess8   : Boolean = false,
+  nSerialPorts : Int = 0,
+  supportQuickAccess : Boolean = false,
+  supportHartArray   : Boolean = false,
+  hartIdToHartSel : (UInt) => UInt = (x:UInt) => x,
+  hartSelToHartId : (UInt) => UInt = (x:UInt) => x
 ) {
 
   if (hasBusMaster == false){
@@ -148,26 +148,15 @@ case class DebugModuleConfig (
 
 }
 
-class DefaultDebugModuleConfig (val xlen:Int /*TODO , val configStringAddr: Int*/)
-    extends DebugModuleConfig(
-      nDMIAddrSize = 7,
-      nProgramBufferWords =  16,
-      // TODO use less for small XLEN?
-      nAbstractDataWords  = (if (xlen == 32) 1 else if (xlen == 64) 2 else 4),
-      nScratch = 1,
-      hasBusMaster = false,
-      hasAccess128 = false, 
-      hasAccess64 = false, 
-      hasAccess32 = false, 
-      hasAccess16 = false, 
-      hasAccess8 = false, 
-      nSerialPorts = 0,
-      supportQuickAccess = false,
-      supportHartArray = false,
-      // TODO configStringAddr = configStringAddr
-      hartIdToHartSel = (x: UInt) => x,
-      hartSelToHartId = (x: UInt) => x
-)
+object DefaultDebugModuleConfig {
+
+  def apply(xlen:Int /*TODO , val configStringAddr: Int*/): DebugModuleConfig = {
+    new DebugModuleConfig().copy(
+      nAbstractDataWords  = (if (xlen == 32) 1 else if (xlen == 64) 2 else 4)
+    )
+  }
+}
+
 
 case object DMKey extends Field[DebugModuleConfig]
 
@@ -840,7 +829,7 @@ class TLDebugModuleInner(device: Device, getNComponents: () => Int)(implicit p:
     abstractGeneratedI.rs1    := 0.U
     abstractGeneratedI.imm    := DATA.U
 
-    abstractGeneratedS.opcode := ((new GeneratedI()).fromBits(rocket.Instructions.SW.value.U)).opcode
+    abstractGeneratedS.opcode := ((new GeneratedS()).fromBits(rocket.Instructions.SW.value.U)).opcode
     abstractGeneratedS.immlo  := (DATA & 0x1F).U
     abstractGeneratedS.funct3 := accessRegisterCommandReg.size
     abstractGeneratedS.rs1    := 0.U