From d10fc84a8b3e1f9c7b132a387c57abfddf766384 Mon Sep 17 00:00:00 2001
From: Howard Mao <zhehao.mao@gmail.com>
Date: Mon, 27 Jun 2016 16:02:47 -0700
Subject: [PATCH] no longer require caching interfaces for groundtest tiles

---
 groundtest                       |  2 +-
 src/main/scala/RocketChip.scala  | 43 +++++++++++++++++++++++++++-----
 src/main/scala/TestConfigs.scala |  2 ++
 uncore                           |  2 +-
 4 files changed, 41 insertions(+), 8 deletions(-)

diff --git a/groundtest b/groundtest
index 961f3543..074d444f 160000
--- a/groundtest
+++ b/groundtest
@@ -1 +1 @@
-Subproject commit 961f3543a5a85a45da5bd36dbf9c16a34f19ecd0
+Subproject commit 074d444f02d6edf8905ecc4feb20763c37f9a767
diff --git a/src/main/scala/RocketChip.scala b/src/main/scala/RocketChip.scala
index 80297587..ab6f7c0d 100644
--- a/src/main/scala/RocketChip.scala
+++ b/src/main/scala/RocketChip.scala
@@ -186,7 +186,9 @@ class Uncore(implicit val p: Parameters) extends Module
     val debugBus = new DebugBusIO()(p).flip
   }
 
-  val outmemsys = Module(new OuterMemorySystem) // NoC, LLC and SerDes
+  val outmemsys = if (nCachedTilePorts + nUncachedTilePorts > 0)
+    Module(new OuterMemorySystem) // NoC, LLC and SerDes
+  else Module(new DummyOuterMemorySystem)
   outmemsys.io.incoherent foreach (_ := false)
   outmemsys.io.tiles_uncached <> io.tiles_uncached
   outmemsys.io.tiles_cached <> io.tiles_cached
@@ -254,19 +256,48 @@ class Uncore(implicit val p: Parameters) extends Module
   }
 }
 
-/** The whole outer memory hierarchy, including a NoC, some kind of coherence
-  * manager agent, and a converter from TileLink to MemIO.
-  */ 
-class OuterMemorySystem(implicit val p: Parameters) extends Module with HasTopLevelParameters {
+abstract class AbstractOuterMemorySystem(implicit val p: Parameters)
+    extends Module with HasTopLevelParameters {
   val io = new Bundle {
     val tiles_cached = Vec(nCachedTilePorts, new ClientTileLinkIO).flip
     val tiles_uncached = Vec(nUncachedTilePorts, new ClientUncachedTileLinkIO).flip
-    val incoherent = Vec(nTiles, Bool()).asInput
+    val incoherent = Vec(nCachedTilePorts, Bool()).asInput
     val mem_axi = Vec(nMemAXIChannels, new NastiIO)
     val mem_ahb = Vec(nMemAHBChannels, new HastiMasterIO)
     val mmio = new ClientUncachedTileLinkIO()(p.alterPartial({case TLId => "L2toMMIO"}))
   }
+}
 
+/** Use in place of OuterMemorySystem if there are no clients to connect. */
+class DummyOuterMemorySystem(implicit p: Parameters) extends AbstractOuterMemorySystem()(p) {
+  require(nCachedTilePorts + nUncachedTilePorts == 0)
+
+  io.mem_axi.foreach { axi =>
+    axi.ar.valid := Bool(false)
+    axi.aw.valid := Bool(false)
+    axi.w.valid := Bool(false)
+    axi.r.ready := Bool(false)
+    axi.b.ready := Bool(false)
+  }
+
+  io.mem_ahb.foreach { ahb =>
+    ahb.htrans := UInt(0)
+    ahb.hmastlock := Bool(false)
+    ahb.hwrite := Bool(false)
+    ahb.haddr := UInt(0)
+    ahb.hburst := UInt(0)
+    ahb.hsize := UInt(0)
+    ahb.hprot := UInt(0)
+  }
+
+  io.mmio.acquire.valid := Bool(false)
+  io.mmio.grant.ready := Bool(false)
+}
+
+/** The whole outer memory hierarchy, including a NoC, some kind of coherence
+  * manager agent, and a converter from TileLink to MemIO.
+  */ 
+class OuterMemorySystem(implicit p: Parameters) extends AbstractOuterMemorySystem()(p) {
   // Create a simple L1toL2 NoC between the tiles and the banks of outer memory
   // Cached ports are first in client list, making sharerToClientId just an indentity function
   // addrToBank is sed to hash physical addresses (of cache blocks) to banks (and thereby memory channels)
diff --git a/src/main/scala/TestConfigs.scala b/src/main/scala/TestConfigs.scala
index 3abe3fe4..9531a650 100644
--- a/src/main/scala/TestConfigs.scala
+++ b/src/main/scala/TestConfigs.scala
@@ -36,6 +36,8 @@ class WithGroundTest extends Config(
         (r: Bool, p: Parameters) =>
           Module(new GroundTestTile(i, r)(p.alterPartial({
             case TLId => "L1toL2"
+            case NCachedTileLinkPorts =>
+              if (p(GroundTestCachedClients) > 0) 1 else 0
             case NUncachedTileLinkPorts => p(GroundTestUncachedClients)
           })))
       }
diff --git a/uncore b/uncore
index 85ba64a9..689a3373 160000
--- a/uncore
+++ b/uncore
@@ -1 +1 @@
-Subproject commit 85ba64a92cc8d6efefb3dcedaf1319355e3f3db1
+Subproject commit 689a3373de64fd3dd6904a6b0f7a2d0d642d6f8d