From 943d7ac80a268b4b6b985bf58ec9a288a39e49d5 Mon Sep 17 00:00:00 2001
From: Andrew Waterman <waterman@eecs.berkeley.edu>
Date: Sat, 15 Mar 2014 17:31:48 -0700
Subject: [PATCH] Use LinkedHashSet/Map for simpler determinism

---
 rocket/src/main/scala/ctrl.scala       | 12 ++++--------
 rocket/src/main/scala/dpath_util.scala |  9 ++-------
 2 files changed, 6 insertions(+), 15 deletions(-)

diff --git a/rocket/src/main/scala/ctrl.scala b/rocket/src/main/scala/ctrl.scala
index 39ce01c5..c87d5cc1 100644
--- a/rocket/src/main/scala/ctrl.scala
+++ b/rocket/src/main/scala/ctrl.scala
@@ -406,19 +406,15 @@ class Control(implicit conf: RocketConfiguration) extends Module
     (x.map(_._1).reduce(_||_), PriorityMux(x))
 
   val fp_csrs = CSRs.fcsr :: CSRs.frm :: CSRs.fflags :: Nil
-  val legal_csrs = if (!conf.fpu.isEmpty) CSRs.all.toSet else CSRs.all.toSet -- fp_csrs
+  val legal_csrs = collection.mutable.LinkedHashSet(CSRs.all:_*)
+  if (conf.fpu.isEmpty)
+    legal_csrs --= fp_csrs
 
   val id_csr_addr = io.dpath.inst(31,20)
   val id_csr_en = id_csr != CSR.N
   val id_csr_fp = Bool(!conf.fpu.isEmpty) && id_csr_en && DecodeLogic(id_csr_addr, fp_csrs, CSRs.all.toSet -- fp_csrs)
   val id_csr_wen = id_raddr1 != UInt(0) || !Vec(CSR.S, CSR.C).contains(id_csr)
-
-  val legal_uint_csrs = new scala.collection.mutable.ArrayBuffer[Bits]
-  for (csr <- legal_csrs) {
-    legal_uint_csrs += UInt(csr)
-  }
-
-  val id_csr_invalid = id_csr_en && !Vec(legal_uint_csrs).contains(id_csr_addr)
+  val id_csr_invalid = id_csr_en && !Vec(legal_csrs.map(UInt(_))).contains(id_csr_addr)
   val id_csr_privileged = id_csr_en &&
     (id_csr_addr(11,10) === UInt(3) && id_csr_wen ||
      id_csr_addr(11,10) === UInt(2) ||
diff --git a/rocket/src/main/scala/dpath_util.scala b/rocket/src/main/scala/dpath_util.scala
index 34af1d8c..e539cbd2 100644
--- a/rocket/src/main/scala/dpath_util.scala
+++ b/rocket/src/main/scala/dpath_util.scala
@@ -213,7 +213,7 @@ class CSRFile(implicit conf: RocketConfiguration) extends Module
   val read_impl = Bits(2)
   val read_ptbr = reg_ptbr(PADDR_BITS-1,PGIDX_BITS) << PGIDX_BITS
 
-  val read_mapping = collection.mutable.Map[Int,Bits](
+  val read_mapping = collection.mutable.LinkedHashMap[Int,Bits](
     CSRs.fflags -> (if (!conf.fpu.isEmpty) reg_fflags else UInt(0)),
     CSRs.frm -> (if (!conf.fpu.isEmpty) reg_frm else UInt(0)),
     CSRs.fcsr -> (if (!conf.fpu.isEmpty) Cat(reg_frm, reg_fflags) else UInt(0)),
@@ -243,12 +243,7 @@ class CSRFile(implicit conf: RocketConfiguration) extends Module
   for (i <- 0 until reg_uarch_counters.size)
     read_mapping += (CSRs.uarch0 + i) -> reg_uarch_counters(i)
 
-  val decoded_mapping = new scala.collection.mutable.ArrayBuffer[(Bool, Bits)]
-  for ((k, v) <- read_mapping) {
-    decoded_mapping += ((decoded_addr(k), v))
-  }
-
-  io.rw.rdata := Mux1H(decoded_mapping)
+  io.rw.rdata := Mux1H(for ((k, v) <- read_mapping) yield decoded_addr(k) -> v)
 
   io.fcsr_rm := reg_frm
   when (io.fcsr_flags.valid) {