1
0

require writes to memory to be uninterrupted

This commit is contained in:
Andrew Waterman 2012-01-03 18:41:53 -08:00
parent 142dfc6e07
commit 938b142d64
2 changed files with 9 additions and 7 deletions

View File

@ -36,13 +36,13 @@ class rocketMemArbiter extends Component {
io.mem.req_val := (io.icache.req_val || io.dcache.req_val); io.mem.req_val := (io.icache.req_val || io.dcache.req_val);
// Set read/write bit. Icache always reads // Set read/write bit. Icache always reads
io.mem.req_rw := Mux(io.icache.req_val,Bool(false),io.dcache.req_rw); io.mem.req_rw := Mux(io.dcache.req_val, io.dcache.req_rw, Bool(false));
// Give priority to Icache // Give priority to Icache
io.mem.req_addr := Mux(io.icache.req_val,io.icache.req_addr,io.dcache.req_addr); io.mem.req_addr := Mux(io.dcache.req_val, io.dcache.req_addr, io.icache.req_addr);
// low bit of tag=0 for I$, 1 for D$ // low bit of tag=0 for I$, 1 for D$
io.mem.req_tag := Cat(Mux(io.icache.req_val, io.icache.req_tag, io.dcache.req_tag), !io.icache.req_val) io.mem.req_tag := Cat(Mux(io.dcache.req_val, io.dcache.req_tag, io.icache.req_tag), io.dcache.req_val)
// Just pass through write data (only D$ will write) // Just pass through write data (only D$ will write)
io.mem.req_wdata := io.dcache.req_wdata; io.mem.req_wdata := io.dcache.req_wdata;
@ -51,9 +51,10 @@ class rocketMemArbiter extends Component {
// Interface to caches // Interface to caches
// ***************************** // *****************************
// Read for request from cache if the memory is ready. Give priority to I$ // Read for request from cache if the memory is ready. Give priority to D$.
io.icache.req_rdy := io.mem.req_rdy; // This way, writebacks will never be interrupted by I$ refills.
io.dcache.req_rdy := io.mem.req_rdy && !io.icache.req_val; io.dcache.req_rdy := io.mem.req_rdy;
io.icache.req_rdy := io.mem.req_rdy && !io.dcache.req_val;
// Response will only be valid for D$ or I$ not both because of tag bits // Response will only be valid for D$ or I$ not both because of tag bits
io.icache.resp_val := io.mem.resp_val && !io.mem.resp_tag(0).toBool; io.icache.resp_val := io.mem.resp_val && !io.mem.resp_tag(0).toBool;

View File

@ -382,8 +382,9 @@ class WritebackUnit extends Component {
val addr = Reg() { new WritebackReq() } val addr = Reg() { new WritebackReq() }
// don't allow memory requests to bypass conflicting writebacks. // don't allow memory requests to bypass conflicting writebacks.
// also don't allow a refill request once a writeback has started.
// TODO: turn this into a victim buffer. // TODO: turn this into a victim buffer.
val block_refill = valid && (io.refill_req.bits.addr(IDX_BITS-1,0) === addr.idx) val block_refill = valid && ((io.refill_req.bits.addr(IDX_BITS-1,0) === addr.idx) || (cnt === UFix(REFILL_CYCLES)))
val refill_val = io.refill_req.valid && !block_refill val refill_val = io.refill_req.valid && !block_refill
wbq.io.q_reset := Bool(false) wbq.io.q_reset := Bool(false)