1
0

clean up the requirements in StatelessBridge

* No need to check that release ID bits and acquire ID bits the same
 * Check that inner and outer coherence policies match
This commit is contained in:
Howard Mao 2016-07-21 18:31:19 -07:00
parent 12067a3b8d
commit 9168f35971

View File

@ -31,22 +31,20 @@ import cde.{Parameters, Field, Config}
*/ */
class ManagerToClientStatelessBridge(implicit p: Parameters) extends HierarchicalCoherenceAgent()(p) { class ManagerToClientStatelessBridge(implicit p: Parameters) extends HierarchicalCoherenceAgent()(p) {
val icid = io.inner.tlClientIdBits
val ixid = io.inner.tlClientXactIdBits
val oxid = io.outer.tlClientXactIdBits
val icid = io.inner.acquire.bits.client_id.getWidth val innerCoh = io.inner.tlCoh.getClass
val ixid = io.inner.acquire.bits.client_xact_id.getWidth val outerCoh = io.outer.tlCoh.getClass
val oxid = io.outer.acquire.bits.client_xact_id.getWidth
// Stateless Bridge is only usable in certain constrained situations. // Stateless Bridge is only usable in certain constrained situations.
// Sanity check its usage here. // Sanity check its usage here.
// Additional requirements are that the inner and outer Coherence policies
// are the same (e.g. MEI != MESI), and that NTiles == 1,
// but this is not checked here.
require (p(NTiles) == 1)
require(io.inner.tlNCachingClients <= 1)
require(icid + ixid <= oxid) require(icid + ixid <= oxid)
require(icid == io.inner.release.bits.client_id.getWidth) require(innerCoh eq outerCoh,
require(ixid == io.inner.release.bits.client_xact_id.getWidth) s"Coherence policies do not match: inner is ${innerCoh.getSimpleName}, outer is ${outerCoh.getSimpleName}")
require(oxid == io.outer.release.bits.client_xact_id.getWidth)
io.outer.acquire.valid := io.inner.acquire.valid io.outer.acquire.valid := io.inner.acquire.valid
io.inner.acquire.ready := io.outer.acquire.ready io.inner.acquire.ready := io.outer.acquire.ready